Add Windows guest control and ConPTY by sjmiller609 · Pull Request #431 · kernel/hypeman

sjmiller609 · 2026-08-20T00:03:40Z

summary

cross-compile the guest agent as a Windows LocalSystem service
listen through the virtio-win VioSock provider while retaining the existing gRPC protocol
add SYSTEM and active-desktop execution sessions
add ConPTY terminal allocation and resize handling
support Windows file copy, stat, readiness, and graceful shutdown
bind command trees to kill-on-close Job Objects and terminate them synchronously
promote Windows instances to Running when guest-agent readiness is proven
move guest-service protocol and lifecycle rationale into lib/system/README.md

targeted tests

guest, guest-agent, and Windows readiness unit tests
Windows guest-agent cross-compilation

Additional terminal signal-parity work is intentionally deferred. Long-running KVM and full CI suites were not run for this review pass.

Note

High Risk
Touches guest command execution, Windows token impersonation, vsock transport, and instance readiness/boot-state derivation. Bugs here can leak processes, run commands in the wrong session, or mis-mark Windows VMs as running.

Overview
Windows guests now run the same guest-agent gRPC protocol as Linux. The agent is cross-compiled as hypeman-guest-agent.exe, installed as the HypemanGuestAgent LocalSystem service, and listens on virtio-win VioSock port 2222.

Exec gains an explicit session field (system vs desktop). Desktop launches use the active interactive token on winsta0\default; ConPTY is SYSTEM-only. Windows commands start suspended, join a kill-on-close Job Object, then resume so timeouts and RPC close tear down the whole process tree. Copy/stat/shutdown work on Windows; network reconfigure is unimplemented.

Windows instances no longer skip the guest agent. Readiness probes use cmd.exe, and a successful agent probe can mark both program-start and agent-ready so the VM becomes Running. The exec API defaults empty commands to cmd.exe on Windows.

CI now builds the Windows agent and runs a QEMU guest-control integration test against /ci/windows/image-agent.qcow2.

^{Reviewed by Cursor Bugbot for commit 89800a9. Bugbot is set up for automated code reviews on this repo. Configure here.}

socket-security · 2026-08-20T00:04:01Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	github.com/aymanbagabas/go-pty@v0.2.2

View full report

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 89800a9. Configure here.}

cursor · 2026-08-21T17:25:05Z

+	}
 	exit, err := guest.ExecIntoInstance(probeCtx, dialer, guest.ExecOptions{
-		Command:      []string{"/bin/true"},
+		Command:      command,


Windows boot markers never persist

High Severity

hydrateBootMarkersFromLogs can promote Windows guests to Running by probing the guest agent and copying that timestamp into ProgramStartedAt, but persistBootMarkers still uses the Linux-only probe gate that requires ProgramStartedAt first. Windows has no program-start serial marker, so the probe never runs on the persist path, markers and the Initializing→Running phase never hit disk, and every later read re-probes without recording time-to-running.

Additional Locations (1)

lib/instances/query.go#L318-L327

^{Reviewed by Cursor Bugbot for commit 89800a9. Configure here.}

sjmiller609 changed the title ~~Add Windows guest control~~ Add Windows guest control and ConPTY Aug 20, 2026

sjmiller609 force-pushed the hypeship/windows-guest-control branch 2 times, most recently from c5bc68c to 0d96de5 Compare August 20, 2026 14:14

sjmiller609 force-pushed the hypeship/windows-guest-control branch from 0d96de5 to 73fd1af Compare August 20, 2026 15:42

sjmiller609 force-pushed the hypeship/windows-guest-control branch from 73fd1af to 7cd7a6e Compare August 20, 2026 16:46